GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 18:41:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix webpack5 builder

Browse Source
This commit is contained in:
Jeppe Reinhold 2022-09-15 13:36:31 +02:00
parent 965fc5a655
commit 46f6374441
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
code/lib/builder-webpack5/src/index.ts
View File

@ -8,7 +8,7 @@ import { checkWebpackVersion } from '@storybook/core-webpack';
export * from './types';
let compilation: ReturnType<typeof webpackDevMiddleware>;
let compilation: ReturnType<typeof webpackDevMiddleware> | undefined;
let reject: (reason?: any) => void;
type WebpackBuilder = Builder<Configuration, Stats>;
@ -72,7 +72,6 @@ export const bail: WebpackBuilder['bail'] = async () => {
}
// we wait for the compiler to finish it's work, so it's command-line output doesn't interfere
return new Promise((res, rej) => {
// @ts-ignore (FIXME: should be expect-error but fails build --prep)
if (process && compilation) {
try {
compilation.close(() => res());
@ -134,7 +133,7 @@ const starter: StarterFunction = async function* starterGeneratorFn({
router.use(webpackHotMiddleware(compiler as any));
const stats = await new Promise<Stats>((ready, stop) => {
compilation.waitUntilValid(ready as any);
compilation?.waitUntilValid(ready as any);
reject = stop;
});
yield;
@ -219,10 +218,9 @@ const builder: BuilderFunction = async function* builderGeneratorFn({ startTime,
logger.trace({ message: '=> Preview built', time: process.hrtime(startTime) });
if (stats && stats.hasWarnings()) {
// @ts-ignore (FIXME should be @ts-expect-error but fails build --prep)
stats
.toJson({ warnings: true } as StatsOptions)
.warnings.forEach((e) => logger.warn(e.message));
.warnings?.forEach((e) => logger.warn(e.message));
}
// https://webpack.js.org/api/node/#run