GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 21:41:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

Addon-knobs: Fix null knob values in select (#9416)

Browse Source 
Addon-knobs: Fix null knob values in select
This commit is contained in:
Michael Shilman 2020-01-14 04:39:54 +08:00 committed by Michael Shilman
parent 39201f2a55
commit 42fa30ba0a
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
addons/knobs/src/components/types/Select.tsx
View File

@ -32,7 +32,7 @@ const SelectType: FunctionComponent<SelectTypeProps> & {
const { options } = knob;
const callbackReduceArrayOptions = (acc: any, option: any, i: number) => {
if (typeof option !== 'object') return { ...acc, [option]: option };
if (typeof option !== 'object' || option === null) return { ...acc, [option]: option };
const label = option.label || option.key || i;
return { ...acc, [label]: option };
};

6
examples/official-storybook/stories/addon-knobs/with-knobs.stories.js
View File

@ -45,6 +45,12 @@ export default {
decorators: [withKnobs],
};
export const selectKnob = () => {
const value = select('value', [1, 2, 3, undefined, null], 1);
return <div>{JSON.stringify({ value: String(value) }, null, 2)}</div>;
};
export const TweaksStaticValues = () => {
const name = text('Name', 'Storyteller');
const age = number('Age', 70, { range: true, min: 0, max: 90, step: 5 });