GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 13:01:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #11202 from sarioglu/next

Browse Source 
Addon-knobs: Update select types for undefined, null and boolean
This commit is contained in:
Michael Shilman 2020-06-18 10:00:26 +08:00 committed by GitHub
commit 428d3f9d55
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
addons/knobs/src/__types__/knob-test-cases.ts
View File

@ -112,6 +112,14 @@ expectKnobOfType<string>(
select<ButtonVariant>('select with string enum options', ButtonVariant, ButtonVariant.primary)
);
expectKnobOfType<string | undefined | null | boolean>(
select(
'select with an undefined in array',
['Apple', 'Banana', 'Grapes', undefined, null, false] as const,
undefined
)
);
expectKnobOfType<string | null>(
select('select with null option', { a: 'Option', b: null }, null, groupId)
);

6
addons/knobs/src/components/types/Select.tsx
View File

@ -4,13 +4,13 @@ import PropTypes from 'prop-types';
import { Form } from '@storybook/components';
import { KnobControlConfig, KnobControlProps } from './types';
export type SelectTypeKnobValue = string | number | null | undefined | PropertyKey[];
export type SelectTypeKnobValue = string | number | boolean | null | undefined | PropertyKey[];
export type SelectTypeOptionsProp<T extends SelectTypeKnobValue = SelectTypeKnobValue> =
| Record<PropertyKey, T>
| Record<Extract<T, PropertyKey>, T[keyof T]>
| Extract<T, PropertyKey>[]
| readonly Extract<T, PropertyKey>[];
| T[]
| readonly T[];
export interface SelectTypeKnob<T extends SelectTypeKnobValue = SelectTypeKnobValue>
extends KnobControlConfig<T> {