GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-05 06:41:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'jeppe/sveltekit-framework-automigration' of github.com:storybookjs/storybook into jeppe/sveltekit-framework-automigration

Browse Source
This commit is contained in:
Jeppe Reinhold 2022-12-09 12:30:58 +01:00
commit 37b69a0d91
3 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
MIGRATION.md
View File

@ -586,7 +586,7 @@ When using a [Vite-based framework](#framework-field-mandatory), Storybook will
Some settings will be overridden by storybook so that it can function properly, and the merged settings can be modified using `viteFinal` in `.storybook/main.js` (see the [Storybook Vite configuration docs](https://storybook.js.org/docs/react/builders/vite#configuration)).
If you were using `viteFinal` in 6.5 to simply merge in your project's standard vite config, you can now remove it.
For Svelte projects this means that the `svelteOptions` property in the `main.js` config can be omitted in most cases, as it will be loaded automatically via the project's `vite.config.js`. An exception to this is when the project needs different Svelte options for Storybook than the Vite config provide for the application itself.
For Svelte projects this means that the `svelteOptions` property in the `main.js` config can be omitted in most cases, as it will be loaded automatically via the project's `vite.config.js`. An exception to this is when the project needs different Svelte options for Storybook than the Vite config provides for the application itself.
#### Vite cache moved to node_modules/.cache/.vite-storybook

2
code/lib/cli/src/automigrate/fixes/sveltekit-framework.test.ts
View File

@ -40,7 +40,7 @@ describe('SvelteKit framework fix', () => {
await expect(checkSvelteKitFramework({ packageJson, main })).resolves.toBeFalsy();
});
describe('in SB > v7.0.0', () => {
describe('in SB >= v7.0.0', () => {
it('in non-SvelteKit projects', async () => {
const packageJson = {
dependencies: { svelte: '^3.53.1', '@storybook/svelte-vite': '^7.0.0' },

1
code/ui/manager/src/components/sidebar/useHighlighted.ts
View File

@ -85,7 +85,6 @@ export const useHighlighted = ({
const isArrowUp = matchesKeyCode('ArrowUp', event);
const isArrowDown = matchesKeyCode('ArrowDown', event);
if (!(isArrowUp || isArrowDown)) return;
event.preventDefault();
const requestId = globalWindow.requestAnimationFrame(() => {
globalWindow.cancelAnimationFrame(lastRequestId);