GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-11 00:06:25 +08:00
Code Issues Packages Projects Releases Wiki Activity

CsfFile: Improve meta error handling and fix failing test

Browse Source
This commit is contained in:
Michael Shilman 2025-01-07 01:41:37 +08:00
parent 84f2ae609c
commit 3753cde16c
2 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
code/core/src/csf-tools/CsfFile.test.ts
View File

@ -2408,7 +2408,7 @@ describe('CsfFile', () => {
`);
});
it.only('local defineConfig', () => {
it('local defineConfig', () => {
expect(() =>
parse(
dedent`

18
code/core/src/csf-tools/CsfFile.ts
View File

@ -521,11 +521,19 @@ export class CsfFile {
self._options.fileName
);
} else if (!self._metaIsFactory && storyIsFactory) {
throw new BadMetaError(
'meta() factory must be imported from .storybook/preview configuration',
storyNode as t.Node,
self._options.fileName
);
if (self._metaNode) {
throw new MixedFactoryError(
'expected non-factory story',
storyNode as t.Node,
self._options.fileName
);
} else {
throw new BadMetaError(
'meta() factory must be imported from .storybook/preview configuration',
storyNode as t.Node,
self._options.fileName
);
}
}
const parameters: { [key: string]: any } = {};
if (t.isObjectExpression(storyNode)) {