GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-09 00:19:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3520 from Grimones/fix-preview-render-order

Browse Source 
Fix render order in preview
This commit is contained in:
Filipp Riabchun 2018-05-02 17:59:21 +03:00 committed by GitHub
commit 3539625d7f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/angular/src/client/preview/render.js vendored
View File

@ -1,6 +1,6 @@
import { renderNgApp } from './angular/helpers';
export default function render({ story, showMain }) {
renderNgApp(story);
showMain();
renderNgApp(story);
}

2
app/mithril/src/client/preview/render.js
View File

@ -21,6 +21,6 @@ export default function renderMain({ story, selectedKind, selectedStory, showMai
return;
}
m.mount(rootEl, { view: () => m(element) });
showMain();
m.mount(rootEl, { view: () => m(element) });
}

3
app/polymer/src/client/preview/render.js
View File

@ -17,6 +17,8 @@ export default function renderMain({ story, selectedKind, selectedStory, showMai
});
return;
}
showMain();
if (typeof component === 'string') {
rootElement.innerHTML = component;
} else if (component instanceof TemplateResult) {
@ -28,5 +30,4 @@ export default function renderMain({ story, selectedKind, selectedStory, showMai
rootElement.innerHTML = '';
rootElement.appendChild(component);
}
showMain();
}

2
app/react/src/client/preview/render.js
View File

@ -43,6 +43,6 @@ export default function renderMain({ story, selectedKind, selectedStory, showMai
// This could leads to issues like below:
// https://github.com/storybooks/react-storybook/issues/81
ReactDOM.unmountComponentAtNode(rootEl);
render(element, rootEl);
showMain();
render(element, rootEl);
}

2
app/vue/src/client/preview/render.js
View File

@ -32,11 +32,11 @@ export default function render({
return;
}
showMain();
renderRoot({
el: '#root',
render(h) {
return h('div', { attrs: { id: 'root' } }, [h(component)]);
},
});
showMain();
}