GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 13:01:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

Resolve circular dependency issue

Browse Source
This commit is contained in:
Tom Coleman 2020-03-02 11:33:59 +11:00
parent 976e30d5d5
commit 333ae484b0
4 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/react/package.json
View File

@ -57,6 +57,7 @@
"webpack": "^4.33.0"
},
"devDependencies": {
"@storybook/client-api": "6.0.0-alpha.15",
"@types/mini-css-extract-plugin": "^0.9.0",
"@types/node": "^13.5.3",
"@types/webpack": "^4.41.0"

3
app/react/src/client/preview/types.ts
View File

@ -1,6 +1,7 @@
import { ReactElement } from 'react';
export { RenderContext } from '@storybook/core';
// eslint-disable-next-line import/no-extraneous-dependencies
export { RenderContext } from '@storybook/client-api';
export interface ShowErrorArgs {
title: string;

10
lib/client-api/src/types.ts
View File

@ -67,3 +67,13 @@ export interface GetStorybookKind {
fileName: string;
stories: GetStorybookStory[];
}
// This really belongs in lib/core, but that depends on lib/ui which (dev) depends on app/react
// which needs this type. So we put it here to avoid the circular dependency problem.
export type RenderContext = StoreItem & {
forceRender: boolean;
showMain: () => void;
showError: (error: { title: string; description: string }) => void;
showException: (err: Error) => void;
};

10
lib/core/src/client/preview/types.ts
View File

@ -1,4 +1,4 @@
import { StoreItem } from '@storybook/client-api';
import { StoreItem, RenderContext } from '@storybook/client-api';
export interface PreviewError {
message?: string;
@ -23,13 +23,7 @@ export type RequireContext = {
export type LoaderFunction = () => void | any[];
export type Loadable = RequireContext | RequireContext[] | LoaderFunction;
export type RenderContext = StoreItem & {
forceRender: boolean;
showMain: () => void;
showError: (error: { title: string; description: string }) => void;
showException: (err: Error) => void;
};
export { RenderContext };
// The function used by a framework to render story to the DOM
export type RenderStoryFunction = (context: RenderContext) => void;