From 65f5703b10e2d63704f6a5bf56bd72164e9ff7e2 Mon Sep 17 00:00:00 2001 From: Norbert de Langen Date: Thu, 8 Nov 2018 15:33:44 +0100 Subject: [PATCH 1/3] CHANGE tests to not output webpack build progress --- .circleci/config.yml | 22 +++++++++---------- ...urceProjects_Storybook_NativeSmokeTests.kt | 2 +- ...OpenSourceProjects_Storybook_SmokeTests.kt | 4 ++-- app/react-native/readme.md | 2 +- lib/cli/test/run_tests.sh | 2 +- 5 files changed, 16 insertions(+), 16 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 95af3d26fe8..8cc1ca4a166 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -120,52 +120,52 @@ jobs: name: Run react kitchen-sink (smoke test) command: | cd examples/cra-kitchen-sink - yarn storybook --smoke-test + yarn storybook --smoke-test --quiet - run: name: Run vue kitchen-sink (smoke test) command: | cd examples/vue-kitchen-sink - yarn storybook --smoke-test + yarn storybook --smoke-test --quiet - run: name: Run svelte kitchen-sink (smoke test) command: | cd examples/svelte-kitchen-sink - yarn storybook --smoke-test + yarn storybook --smoke-test --quiet - run: name: Run angular-cli (smoke test) command: | cd examples/angular-cli - yarn storybook --smoke-test + yarn storybook --smoke-test --quiet - run: name: Run ember-cli (smoke test) command: | cd examples/ember-cli - yarn storybook --smoke-test + yarn storybook --smoke-test --quiet - run: name: Run polymer-cli (smoke test) command: | cd examples/polymer-cli - yarn storybook --smoke-test + yarn storybook --smoke-test --quiet - run: name: Run marko-cli (smoke test) command: | cd examples/marko-cli - yarn storybook --smoke-test + yarn storybook --smoke-test --quiet - run: name: Run official-storybook (smoke test) command: | cd examples/official-storybook - yarn storybook --smoke-test + yarn storybook --smoke-test --quiet - run: name: Run mithril kitchen-sink (smoke test) command: | cd examples/mithril-kitchen-sink - yarn storybook --smoke-test + yarn storybook --smoke-test --quiet - run: name: Run riot kitchen-sink (smoke test) command: | cd examples/riot-kitchen-sink - yarn storybook --smoke-test + yarn storybook --smoke-test --quiet native-smoke-tests: <<: *defaults steps: @@ -179,7 +179,7 @@ jobs: name: Run React-Native-App example command: | cd examples-native/crna-kitchen-sink - yarn storybook --smoke-test + yarn storybook --smoke-test --quiet docs: <<: *defaults steps: diff --git a/.teamcity/OpenSourceProjects_Storybook/buildTypes/OpenSourceProjects_Storybook_NativeSmokeTests.kt b/.teamcity/OpenSourceProjects_Storybook/buildTypes/OpenSourceProjects_Storybook_NativeSmokeTests.kt index d1e3319c8d9..6c1719f737e 100644 --- a/.teamcity/OpenSourceProjects_Storybook/buildTypes/OpenSourceProjects_Storybook_NativeSmokeTests.kt +++ b/.teamcity/OpenSourceProjects_Storybook/buildTypes/OpenSourceProjects_Storybook_NativeSmokeTests.kt @@ -30,7 +30,7 @@ object OpenSourceProjects_Storybook_NativeSmokeTests : BuildType({ yarn yarn bootstrap --reactnativeapp cd examples-native/crna-kitchen-sink - yarn storybook --smoke-test + yarn storybook --smoke-test --quiet """.trimIndent() dockerImage = "node:%docker.node.version%" } diff --git a/.teamcity/OpenSourceProjects_Storybook/buildTypes/OpenSourceProjects_Storybook_SmokeTests.kt b/.teamcity/OpenSourceProjects_Storybook/buildTypes/OpenSourceProjects_Storybook_SmokeTests.kt index bf5f2ebf439..377397880bc 100644 --- a/.teamcity/OpenSourceProjects_Storybook/buildTypes/OpenSourceProjects_Storybook_SmokeTests.kt +++ b/.teamcity/OpenSourceProjects_Storybook/buildTypes/OpenSourceProjects_Storybook_SmokeTests.kt @@ -30,7 +30,7 @@ object OpenSourceProjects_Storybook_SmokeTests : BuildType({ set -e -x cd examples/$exampleDir - yarn storybook --smoke-test + yarn storybook --smoke-test --quiet """.trimIndent() dockerImage = "node:%docker.node.version%" } @@ -44,7 +44,7 @@ object OpenSourceProjects_Storybook_SmokeTests : BuildType({ set -e -x cd examples/official-storybook - yarn storybook --smoke-test + yarn storybook --smoke-test --quiet """.trimIndent() dockerImage = "node:%docker.node.version%" } diff --git a/app/react-native/readme.md b/app/react-native/readme.md index afbda79010e..cfc38cc38b4 100644 --- a/app/react-native/readme.md +++ b/app/react-native/readme.md @@ -131,4 +131,4 @@ You can pass these parameters to getStorybookUI call in your storybook entry poi ## Learn More -Check the `docs` directory in this repo for more advanced setup guides and other info. \ No newline at end of file +Check the `docs` directory in this repo for more advanced setup guides and other info. diff --git a/lib/cli/test/run_tests.sh b/lib/cli/test/run_tests.sh index e303df18119..951b50c37f7 100755 --- a/lib/cli/test/run_tests.sh +++ b/lib/cli/test/run_tests.sh @@ -62,7 +62,7 @@ do echo "Running smoke test in $dir" failed=0 - yarn storybook --smoke-test || failed=1 + yarn storybook --smoke-test --quiet || failed=1 if [ $teamcity -eq 1 ] then From 53dc825289d5f13fd317988658c15b41d5e38d63 Mon Sep 17 00:00:00 2001 From: Norbert de Langen Date: Thu, 8 Nov 2018 17:11:56 +0100 Subject: [PATCH 2/3] REMOVE quiet flag for tests for RN, (it's always silent) --- .circleci/config.yml | 2 +- .../buildTypes/OpenSourceProjects_Storybook_NativeSmokeTests.kt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 8cc1ca4a166..76cc6666676 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -179,7 +179,7 @@ jobs: name: Run React-Native-App example command: | cd examples-native/crna-kitchen-sink - yarn storybook --smoke-test --quiet + yarn storybook --smoke-test docs: <<: *defaults steps: diff --git a/.teamcity/OpenSourceProjects_Storybook/buildTypes/OpenSourceProjects_Storybook_NativeSmokeTests.kt b/.teamcity/OpenSourceProjects_Storybook/buildTypes/OpenSourceProjects_Storybook_NativeSmokeTests.kt index 6c1719f737e..d1e3319c8d9 100644 --- a/.teamcity/OpenSourceProjects_Storybook/buildTypes/OpenSourceProjects_Storybook_NativeSmokeTests.kt +++ b/.teamcity/OpenSourceProjects_Storybook/buildTypes/OpenSourceProjects_Storybook_NativeSmokeTests.kt @@ -30,7 +30,7 @@ object OpenSourceProjects_Storybook_NativeSmokeTests : BuildType({ yarn yarn bootstrap --reactnativeapp cd examples-native/crna-kitchen-sink - yarn storybook --smoke-test --quiet + yarn storybook --smoke-test """.trimIndent() dockerImage = "node:%docker.node.version%" } From 3d31fd33a40185cd3991cc9baff75a0914a071f2 Mon Sep 17 00:00:00 2001 From: Norbert de Langen Date: Thu, 8 Nov 2018 17:47:20 +0100 Subject: [PATCH 3/3] CHANGE start command for RN to allow --quiet --- app/react-native/src/bin/storybook-start.js | 1 + 1 file changed, 1 insertion(+) diff --git a/app/react-native/src/bin/storybook-start.js b/app/react-native/src/bin/storybook-start.js index ebdae9425db..b049f2815d5 100644 --- a/app/react-native/src/bin/storybook-start.js +++ b/app/react-native/src/bin/storybook-start.js @@ -5,6 +5,7 @@ import program from 'commander'; import Server from '../server'; program + .allowUnknownOption() .option('-h, --host ', 'host to listen on', 'localhost') .option('-p, --port ', 'port to listen on', 7007) .option('-s, --secured', 'whether server is running on https')