GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-06 07:21:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

add a try catch around the managerEntries so they can't disrupt other managerEntires being loaded

Browse Source
This commit is contained in:
Norbert de Langen 2022-12-15 16:35:56 +01:00
parent 218502fc3f
commit 30119a6bec
No known key found for this signature in database
GPG Key ID: FD0E78AF9A837762
2 changed files with 13 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
code/lib/builder-manager/src/index.ts
View File

@ -77,6 +77,14 @@ export const getConfig: ManagerBuilder['getConfig'] = async (options) => {
globalExternals(definitions),
pnpPlugin(),
],
banner: {
js: 'try{',
},
footer: {
js: '}catch(e){ console.log("ONE OF YOUR MANAGER-ENTRIES FAILED: " + import.meta.url) }',
},
define: {
'process.env.NODE_ENV': "'production'",
'process.env': '{}',

16
code/lib/builder-manager/templates/template.ejs
View File

@ -8,7 +8,6 @@
<link rel="icon" type="image/svg+xml" href="./favicon.svg">
<meta name="viewport" content="width=device-width, initial-scale=1" />
<link href="./sb-preview/runtime.mjs" rel="preload" as="script">
<% if (typeof head !== 'undefined') { %> <%- head %> <% } %>
@ -38,20 +37,11 @@
<script type="module">
import './sb-manager/runtime.mjs';
const addons = [
<% files.js.forEach(file => { %>
'./<%= file %>',
import '<%= file %>';
<% }); %>
];
/* error handling of manager-addons being broken */
const results = await Promise.allSettled(addons.map(addon => import(addon))).then(results => {
results.forEach((result, index) => {
if(result.status =='rejected'){
console.error(`loading ${addons[index]} failed to load correctly`);
}
})
});
</script>
<link href="./sb-preview/runtime.mjs" rel="preload" as="script">
</body>
</html>