GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 20:51:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

IMPROVE wording of test & code-comment

Browse Source 
https://github.com/storybookjs/storybook/pull/10159#issuecomment-602307356
This commit is contained in:
Norbert de Langen 2020-03-23 11:03:04 +01:00
parent c6505e862c
commit 2ea4cb566a
No known key found for this signature in database
GPG Key ID: 976651DA156C2825
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/core/src/server/preview/entries.js
View File

@ -8,7 +8,8 @@ export const sortEntries = entries => {
const isGeneratedConfig = /(?:preview|config)\..+-generated-config-entry/;
return stable(entries.slice(0), (a, b) => {
// preview & config can call configure which should always happen AFTER all global decorators & args are set
// We need to ensure that all parameters and decorators that are added by preview entrypoints added by addons happen before any configure() calls executed by the user's preview.js (or config.js), or by main.js:stories.
// As those addons will create generated entries, this means we need to ensure all generated entries come before all other entries (generated or otherwise).
switch (true) {
case !!a.match(isGeneratedConfig) && !!b.match(isGenerated): {

2
lib/core/src/server/preview/entries.test.js
View File

@ -34,7 +34,7 @@ describe('sortEntries', () => {
'/Users/dev/Projects/GitHub/storybook/core/examples/web-components-kitchen-sink/.storybook/preview.js-generated-config-entry.js',
]);
});
it('should move stories-type all other generated entries', () => {
it('should move stories-type after all other generated entries', () => {
const input = [
'/Users/dev/Projects/GitHub/storybook/core/lib/core/dist/server/common/polyfills.js',
'/Users/dev/Projects/GitHub/storybook/core/lib/core/dist/server/preview/globals.js',