GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-05 16:11:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

ADD codepath for prereleases, they should not trigger a updateNotification

Browse Source
This commit is contained in:
Norbert de Langen 2019-10-23 21:07:19 +02:00
parent d49c1aab4b
commit 2c7b76e05c
2 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/api/src/modules/versions.ts
View File

@ -89,7 +89,9 @@ export default function({ store, mode }: Module) {
const diff = semver.diff(current.version, latest.version);
return semver.gt(latest.version, current.version) && diff !== 'patch';
return (
semver.gt(latest.version, current.version) && diff !== 'patch' && !diff.includes('pre')
);
}
return false;
},

18
lib/api/src/tests/versions.test.js
View File

@ -239,5 +239,23 @@ describe('versions API', () => {
expect(api.versionUpdateAvailable()).toEqual(true);
});
it('new prerelease version', async () => {
const store = createMockStore();
const { api, init, state: initialState } = initVersions({ store });
await init({ api: { ...api, addNotification: jest.fn() } });
store.setState({
...initialState,
versions: {
...initialState.versions,
current: { version: '5.2.1' },
latest: { version: '6.2.1-prerelease.0' },
},
});
expect(api.versionUpdateAvailable()).toEqual(false);
});
});
});