GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-06 02:51:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

🐛 bug(knobs): fixed infinite render loop

Browse Source 
closes #1747
This commit is contained in:
kazuya kawaguchi 2017-10-20 13:00:55 +09:00
parent 1e7ec0564b
commit 28e72cb6b1
No known key found for this signature in database
GPG Key ID: 92C928952CA5309E
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
addons/knobs/src/vue/index.js
View File

@ -1,6 +1,14 @@
export const vueHandler = (channel, knobStore) => getStory => context => ({ export const vueHandler = (channel, knobStore) => getStory => context => ({
data() {
return {
context,
getStory,
story: getStory(context),
};
},
render(h) { render(h) {
return h(getStory(context)); return h(this.story);
}, },
methods: { methods: {
@ -10,6 +18,7 @@ export const vueHandler = (channel, knobStore) => getStory => context => ({
const knobOptions = knobStore.get(name); const knobOptions = knobStore.get(name);
knobOptions.value = value; knobOptions.value = value;
this.story = this.getStory(this.context);
this.$forceUpdate(); this.$forceUpdate();
}, },
@ -21,6 +30,7 @@ export const vueHandler = (channel, knobStore) => getStory => context => ({
onKnobReset() { onKnobReset() {
knobStore.reset(); knobStore.reset();
this.setPaneKnobs(false); this.setPaneKnobs(false);
this.story = this.getStory(this.context);
this.$forceUpdate(); this.$forceUpdate();
}, },