GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 23:01:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix review comments

Browse Source
This commit is contained in:
Michael Shilman 2021-09-30 17:35:17 +08:00
parent 1fd8294e3e
commit 2744fb78ba
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/cli/src/generators/REACT_SCRIPTS/index.ts
View File

@ -25,10 +25,10 @@ const generator: Generator = async (packageManager, npmOptions, options) => {
const craVersion = semver.coerce(
packageManager.retrievePackageJson().dependencies['react-scripts']
)?.version;
const isWebpack5 = semver.gte(craVersion, '5.0.0');
const updatedOptions = isWebpack5 ? { ...options, builder: CoreBuilder.Webpack5 } : options;
const isCra5 = semver.gte(craVersion, '5.0.0');
const updatedOptions = isCra5 ? { ...options, builder: CoreBuilder.Webpack5 } : options;
const extraPackages = ['@storybook/node-logger'];
if (isWebpack5) extraPackages.push('webpack');
if (isCra5) extraPackages.push('webpack');
await baseGenerator(packageManager, npmOptions, updatedOptions, 'react', {
extraAddons: ['@storybook/preset-create-react-app'],