From 25e9208e8a882ec766077c3f250f5af4cdff585b Mon Sep 17 00:00:00 2001
From: Tom Coleman <tom@thesnail.org>
Date: Wed, 12 May 2021 12:54:11 +1000
Subject: [PATCH] Remove all defaultValue eval-ing in addon-docs

---
 .../src/frameworks/react/extractArgTypes.ts   | 30 +++++++------------
 .../src/frameworks/svelte/extractArgTypes.ts  |  1 -
 .../src/frameworks/vue/extractArgTypes.ts     |  8 -----
 .../src/frameworks/vue3/extractArgTypes.ts    |  7 -----
 4 files changed, 11 insertions(+), 35 deletions(-)

diff --git a/addons/docs/src/frameworks/react/extractArgTypes.ts b/addons/docs/src/frameworks/react/extractArgTypes.ts
index 92ad351a8c7..177248ad367 100644
--- a/addons/docs/src/frameworks/react/extractArgTypes.ts
+++ b/addons/docs/src/frameworks/react/extractArgTypes.ts
@@ -7,26 +7,18 @@ export const extractArgTypes: ArgTypesExtractor = (component) => {
     const { rows } = extractProps(component);
     if (rows) {
       return rows.reduce((acc: ArgTypes, row: PropDef) => {
-        const { name, type, sbType, defaultValue: defaultSummary, jsDocTags, required } = row;
+        const {
+          name,
+          type,
+          sbType,
+          defaultValue: defaultSummary,
+          jsDocTags,
+          required,
+          ...rest
+        } = row;
 
-        let defaultValue;
-        if (component.defaultProps) {
-          defaultValue = component.defaultProps[name];
-        } else {
-          const defaultValueString =
-            defaultSummary && (defaultSummary.detail || defaultSummary.summary);
-          try {
-            if (defaultValueString) {
-              // eslint-disable-next-line no-new-func
-              defaultValue = Function(`"use strict";return (${defaultValueString})`)();
-            }
-            // eslint-disable-next-line no-empty
-          } catch {}
-        }
-
-        acc[row.name] = {
-          ...row,
-          defaultValue,
+        acc[name] = {
+          ...rest,
           type: { required, ...sbType },
           table: {
             type,
diff --git a/addons/docs/src/frameworks/svelte/extractArgTypes.ts b/addons/docs/src/frameworks/svelte/extractArgTypes.ts
index 09ea906f1f8..bf81d28bfbb 100644
--- a/addons/docs/src/frameworks/svelte/extractArgTypes.ts
+++ b/addons/docs/src/frameworks/svelte/extractArgTypes.ts
@@ -41,7 +41,6 @@ export const createArgTypes = (docgen: SvelteComponentDoc) => {
         required: hasKeyword('required', item.keywords),
         summary: item.type?.text,
       },
-      defaultValue: item.defaultValue,
       table: {
         type: {
           summary: item.type?.text,
diff --git a/addons/docs/src/frameworks/vue/extractArgTypes.ts b/addons/docs/src/frameworks/vue/extractArgTypes.ts
index ca65e50f1e3..d41a155adda 100644
--- a/addons/docs/src/frameworks/vue/extractArgTypes.ts
+++ b/addons/docs/src/frameworks/vue/extractArgTypes.ts
@@ -17,18 +17,10 @@ export const extractArgTypes: ArgTypesExtractor = (component) => {
     props.forEach(({ propDef, docgenInfo, jsDocTags }) => {
       const { name, type, description, defaultValue: defaultSummary, required } = propDef;
       const sbType = section === 'props' ? convert(docgenInfo) : { name: 'void' };
-      let defaultValue = defaultSummary && (defaultSummary.detail || defaultSummary.summary);
-      try {
-        // eslint-disable-next-line no-eval
-        defaultValue = eval(defaultValue);
-        // eslint-disable-next-line no-empty
-      } catch {}
-
       results[name] = {
         name,
         description,
         type: { required, ...sbType },
-        defaultValue,
         table: {
           type,
           jsDocTags,
diff --git a/addons/docs/src/frameworks/vue3/extractArgTypes.ts b/addons/docs/src/frameworks/vue3/extractArgTypes.ts
index 6a264ad6f6d..1555b6d6acc 100644
--- a/addons/docs/src/frameworks/vue3/extractArgTypes.ts
+++ b/addons/docs/src/frameworks/vue3/extractArgTypes.ts
@@ -14,18 +14,11 @@ export const extractArgTypes: ArgTypesExtractor = (component) => {
     props.forEach(({ propDef, docgenInfo, jsDocTags }) => {
       const { name, type, description, defaultValue: defaultSummary, required } = propDef;
       const sbType = section === 'props' ? convert(docgenInfo) : { name: 'void' };
-      let defaultValue = defaultSummary && (defaultSummary.detail || defaultSummary.summary);
-      try {
-        // eslint-disable-next-line no-eval
-        defaultValue = eval(defaultValue);
-        // eslint-disable-next-line no-empty
-      } catch {}
 
       results[name] = {
         name,
         description,
         type: { required, ...sbType },
-        defaultValue,
         table: {
           type,
           jsDocTags,