From bc9d5e128b66bd8087fb6aae7bbf2c93dc0c0ac9 Mon Sep 17 00:00:00 2001 From: Joscha Feth Date: Mon, 10 Apr 2017 15:59:11 +1000 Subject: [PATCH 1/5] Add typescript definitions for getStorybook() `2.35.3` add `getStorybook()` in 86d5819a7b8843a1331c33eb7bef17bae0d98006, but Typescript definitions were not updated. --- config/storybook.d.ts | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/config/storybook.d.ts b/config/storybook.d.ts index ba6252ae7f1..618326eda08 100644 --- a/config/storybook.d.ts +++ b/config/storybook.d.ts @@ -1,7 +1,9 @@ declare var module: any; // dangerous +type RenderFunction = Function; + interface StoryDecorator { - (story: Function, context: { kind: string, story: string }): Object | null; + (story: RenderFunction, context: { kind: string, story: string }): Object; } interface Story { @@ -13,3 +15,15 @@ export function addDecorator(decorator: StoryDecorator): void; export function linkTo(name: string, ...params: any[]): void; export function storiesOf(name: string, module: any): Story; export function action(name: string, ...params: any[]): any; + +type StoryObject = { + name: string, + render: RenderFunction, +}; + +type StoryBucket = { + kind: string, + stories: StoryObject[], +}; + +export function getStorybook(): StoryBucket[]; From 0e9d7dea4eb1d8d699a2021f775a65852ed2910e Mon Sep 17 00:00:00 2001 From: Joscha Feth Date: Mon, 10 Apr 2017 17:54:18 +1000 Subject: [PATCH 2/5] Also add `configure` --- config/storybook.d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/config/storybook.d.ts b/config/storybook.d.ts index 618326eda08..f454f3e56b1 100644 --- a/config/storybook.d.ts +++ b/config/storybook.d.ts @@ -12,6 +12,7 @@ interface Story { } export function addDecorator(decorator: StoryDecorator): void; +export function configure(fn: Function, module: any): void; export function linkTo(name: string, ...params: any[]): void; export function storiesOf(name: string, module: any): Story; export function action(name: string, ...params: any[]): any; From dd49bda93ea033dccec7e84b4c9361c553300388 Mon Sep 17 00:00:00 2001 From: Joscha Feth Date: Thu, 13 Apr 2017 10:51:46 +1000 Subject: [PATCH 3/5] Update storybook.d.ts Incorporate https://github.com/storybooks/react-storybook/pull/680 --- config/storybook.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/storybook.d.ts b/config/storybook.d.ts index f454f3e56b1..a7c34ab3c8b 100644 --- a/config/storybook.d.ts +++ b/config/storybook.d.ts @@ -3,7 +3,7 @@ declare var module: any; // dangerous type RenderFunction = Function; interface StoryDecorator { - (story: RenderFunction, context: { kind: string, story: string }): Object; + (story: RenderFunction, context: { kind: string, story: string }): Object | null; } interface Story { From 348bef4d70da7cb0e981e8c32940c662d97ac535 Mon Sep 17 00:00:00 2001 From: Michael Shilman Date: Wed, 19 Apr 2017 07:41:53 -0700 Subject: [PATCH 4/5] Restore docs deep link for addon gallery --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 095a7ea1a58..21dd38587e1 100644 --- a/README.md +++ b/README.md @@ -13,7 +13,7 @@ Storybook is a development environment for React UI components. It allows you to Storybook runs outside of your app. This allows you to develop UI components in isolation, which can improve component reuse, testability, and development speed. You can build quickly without having to worry about application-specific dependencies. -Storybook comes with a lot of [addons](https://storybooks.js.org) for component design, documentation, testing, interactivity, and so on. Storybook's easy-to-use API makes it easy to configure and extend in various ways. It has even been extended to support React Native development for mobile. +Storybook comes with a lot of [addons](https://storybooks.js.org/docs/react-storybook/addons/introduction) for component design, documentation, testing, interactivity, and so on. Storybook's easy-to-use API makes it easy to configure and extend in various ways. It has even been extended to support React Native development for mobile. ## Getting Started From 4b301cdc102fe77f9623f13043d20dff338bd96d Mon Sep 17 00:00:00 2001 From: Michael Shilman Date: Wed, 19 Apr 2017 15:14:14 -0700 Subject: [PATCH 5/5] Fix default storybook webpack --- .../src/server/config/defaults/webpack.config.js | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/packages/react-storybook/src/server/config/defaults/webpack.config.js b/packages/react-storybook/src/server/config/defaults/webpack.config.js index 69ec7d68f6a..b82ed7b4864 100644 --- a/packages/react-storybook/src/server/config/defaults/webpack.config.js +++ b/packages/react-storybook/src/server/config/defaults/webpack.config.js @@ -1,5 +1,6 @@ +import webpack from 'webpack'; import autoprefixer from 'autoprefixer'; -import { includePaths } from '../utils'; +import { includePaths, excludePaths } from '../utils'; // Add a default custom config which is similar to what React Create App does. module.exports = storybookBaseConfig => { @@ -57,12 +58,6 @@ module.exports = storybookBaseConfig => { }, ]; - newConfig.postcss = () => [ - autoprefixer({ - browsers: ['>1%', 'last 4 versions', 'Firefox ESR', 'not ie < 9'], - }), - ]; - newConfig.resolve.alias = { ...storybookBaseConfig.resolve.alias, // This is to support NPM2