GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 13:31:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4222 from EloB/patch-1

Browse Source 
Fix broken colorpicker for knobs
This commit is contained in:
Norbert de Langen 2018-09-27 08:51:30 +02:00 committed by GitHub
commit 1717f9f4b9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
addons/knobs/src/components/types/Color.js
View File

@ -28,10 +28,13 @@ class ColorType extends React.Component {
document.addEventListener('mousedown', this.handleWindowMouseDown);
}
shouldComponentUpdate(nextProps) {
shouldComponentUpdate(nextProps, nextState) {
const { knob } = this.props;
const { displayColorPicker } = this.state;
return nextProps.knob.value !== knob.value;
return (
nextProps.knob.value !== knob.value || nextState.displayColorPicker !== displayColorPicker
);
}
componentWillUnmount() {