GitHub/storybook
1
0
Fork 0
mirror of https://github.com/storybookjs/storybook.git synced 2025-04-04 16:51:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

Re-enable failing args tests

Browse Source
This commit is contained in:
Michael Shilman 2020-03-14 09:16:12 +08:00
parent 53c93c1562
commit 01545dd723
2 changed files with 72 additions and 69 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

130
lib/client-api/src/story_store.test.ts
View File

@ -199,75 +199,75 @@ describe('preview.story_store', () => {
});
describe('globalArgs', () => {
// it('is initialized to the value stored in parameters.globalArgs on the first story', () => {
// const store = new StoryStore({ channel });
// addStoryToStore(store, 'a', '1', () => 0, {
// globalArgs: {
// arg1: 'arg1',
// arg2: 2,
// arg3: { complex: { object: ['type'] } },
// },
// });
// store.finishConfiguring();
// expect(store.getRawStory('a', '1').globalArgs).toEqual({
// arg1: 'arg1',
// arg2: 2,
// arg3: { complex: { object: ['type'] } },
// });
// });
it('is initialized to the value stored in parameters.globalArgs on the first story', () => {
const store = new StoryStore({ channel });
addStoryToStore(store, 'a', '1', () => 0, {
globalArgs: {
arg1: 'arg1',
arg2: 2,
arg3: { complex: { object: ['type'] } },
},
});
store.finishConfiguring();
expect(store.getRawStory('a', '1').globalArgs).toEqual({
arg1: 'arg1',
arg2: 2,
arg3: { complex: { object: ['type'] } },
});
});
// it('is initialized to the default values stored in parameters.globalArgsTypes on the first story', () => {
// const store = new StoryStore({ channel });
// addStoryToStore(store, 'a', '1', () => 0, {
// globalArgs: {
// arg1: 'arg1',
// arg2: 2,
// },
// globalArgTypes: {
// arg2: { defaultValue: 'arg2' },
// arg3: { defaultValue: { complex: { object: ['type'] } } },
// },
// });
// store.finishConfiguring();
// expect(store.getRawStory('a', '1').globalArgs).toEqual({
// arg1: 'arg1',
// arg2: 2,
// arg3: { complex: { object: ['type'] } },
// });
// });
it('is initialized to the default values stored in parameters.globalArgsTypes on the first story', () => {
const store = new StoryStore({ channel });
addStoryToStore(store, 'a', '1', () => 0, {
globalArgs: {
arg1: 'arg1',
arg2: 2,
},
globalArgTypes: {
arg2: { defaultValue: 'arg2' },
arg3: { defaultValue: { complex: { object: ['type'] } } },
},
});
store.finishConfiguring();
expect(store.getRawStory('a', '1').globalArgs).toEqual({
arg1: 'arg1',
arg2: 2,
arg3: { complex: { object: ['type'] } },
});
});
// it('on HMR it sensibly re-initializes with memory', () => {
// const store = new StoryStore({ channel });
// addons.setChannel(channel);
// addStoryToStore(store, 'a', '1', () => 0, {
// globalArgs: {
// arg1: 'arg1',
// arg2: 2,
// arg3: { complex: { object: ['type'] } },
// },
// });
// store.finishConfiguring();
it('on HMR it sensibly re-initializes with memory', () => {
const store = new StoryStore({ channel });
addons.setChannel(channel);
addStoryToStore(store, 'a', '1', () => 0, {
globalArgs: {
arg1: 'arg1',
arg2: 2,
arg3: { complex: { object: ['type'] } },
},
});
store.finishConfiguring();
// // HMR
// store.startConfiguring();
// store.removeStoryKind('a');
// addStoryToStore(store, 'a', '1', () => 0, {
// globalArgs: {
// arg2: 2,
// // Although we have changed the default there is no way to tell that the user didn't change
// // it themselves
// arg3: { complex: { object: ['changed'] } },
// arg4: 'new',
// },
// });
// store.finishConfiguring();
// HMR
store.startConfiguring();
store.removeStoryKind('a');
addStoryToStore(store, 'a', '1', () => 0, {
globalArgs: {
arg2: 2,
// Although we have changed the default there is no way to tell that the user didn't change
// it themselves
arg3: { complex: { object: ['changed'] } },
arg4: 'new',
},
});
store.finishConfiguring();
// expect(store.getRawStory('a', '1').globalArgs).toEqual({
// arg2: 2,
// arg3: { complex: { object: ['type'] } },
// arg4: 'new',
// });
// });
expect(store.getRawStory('a', '1').globalArgs).toEqual({
arg2: 2,
arg3: { complex: { object: ['type'] } },
arg4: 'new',
});
});
it('updateGlobalArgs changes the global args', () => {
const store = new StoryStore({ channel });

11
lib/client-api/src/story_store.ts
View File

@ -53,14 +53,17 @@ const includeStory = (story: StoreItem, options: StoryOptions = { includeDocsOnl
return !isStoryDocsOnly(story.parameters);
};
const inJest = () => process.env.JEST_WORKER_ID !== undefined;
const checkGlobalArgs = (parameters: Parameters) => {
const { globalArgs, globalArgTypes } = parameters;
if (globalArgs || globalArgTypes) {
throw new Error(
`Global args/argTypes can only be set globally: ${JSON.stringify({
if ((globalArgs || globalArgTypes) && !inJest()) {
logger.error(
'Global args/argTypes can only be set globally',
JSON.stringify({
globalArgs,
globalArgTypes,
})}`
})
);
}
};