mirror of
https://github.com/google/flatbuffers.git
synced 2025-04-08 01:02:04 +08:00
7106d86685
When flatbuffers is being used from a project that has no use for
JavaScript, users encounter an error similar to the following:
ERROR: Skipping '@com_github_google_flatbuffers//:flatbuffers': error loading package '@com_github_google_flatbuffers//': Unable to find package for @npm//:defs.bzl: The repository '@npm' could not be resolved: Repository '@npm' is not defined.
WARNING: Target pattern parsing failed.
ERROR: error loading package '@com_github_google_flatbuffers//': Unable to find package for @npm//:defs.bzl: The repository '@npm' could not be resolved: Repository '@npm' is not defined.
INFO: Elapsed time: 0.023s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)
currently loading: @com_github_google_flatbuffers//
That's not ideal. Users that only care about C++ for example
shouldn't be forced to deal with rules_js and friends.
This patch attempts to fix that by moving the rules_js-specific things
into the `ts` and `tests/ts` directories. This should allow
non-JavaScript projects to ignore rules_js and friends completely.
Here I basically followed the `rules_foo` example from rules_js:
https://github.com/aspect-build/rules_js/tree/main/e2e/rules_foo
The idea is that flatbuffers has its own npm dependencies regardless
of what other projects may have. This means we should not force the
user to import flatbuffers's npm dependencies. The new
`ts/repositories.bzl` file is used by dependents to import
flatbuffers's dependencies. They can still import their own
dependencies. This cleanup allowed me to move all
JavaScript-specific stuff from the top-level directory into
subdirectories.
There should be no changes in this patch in terms of functionality.
It's just a refactor of the rules_js call sites. Users will have to
add a call to the function in `ts/repositories.bzl` in their own
`WORKSPACE` file. They can use
`tests/ts/bazel_repository_test/WORKSPACE` as an example.
Co-authored-by: Derek Bailey <derekbailey@google.com>
49 lines
1.6 KiB
Python
49 lines
1.6 KiB
Python
"""Helper macros and rules for tests."""
|
|
|
|
load("@bazel_skylib//lib:paths.bzl", "paths")
|
|
load("@bazel_skylib//rules:expand_template.bzl", "expand_template")
|
|
|
|
def flatbuffers_as_external_repo_test(name, directory):
|
|
"""Run all tests in a bazel workspace that imports flatbuffers as an external repository.
|
|
|
|
Args:
|
|
name: The name of the test target.
|
|
directory: The directory in which the bazel workspace is located. This is the directory
|
|
that imports flatbuffers as an external repository.
|
|
"""
|
|
expand_template(
|
|
name = name + "__template_expansion",
|
|
out = name + ".sh",
|
|
substitutions = {
|
|
"{{REPOSITORY_DIR}}": paths.join(native.package_name(), directory),
|
|
},
|
|
template = "//tests:bazel_repository_test_template.sh",
|
|
)
|
|
|
|
native.sh_test(
|
|
name = name,
|
|
srcs = [":%s.sh" % name],
|
|
data = [
|
|
"//:distribution",
|
|
"@bazel_linux_x86_64//file",
|
|
] + native.glob(
|
|
[
|
|
directory + "/**/*",
|
|
],
|
|
exclude = [
|
|
directory + "/bazel-*/**",
|
|
],
|
|
),
|
|
tags = [
|
|
# Since we have bazel downloading external repositories inside this
|
|
# test, we need to give it access to the internet.
|
|
"requires-network",
|
|
],
|
|
# We only have x86_64 Linux bazel exposed so restrict the test to that.
|
|
target_compatible_with = [
|
|
"@platforms//cpu:x86_64",
|
|
"@platforms//os:linux",
|
|
],
|
|
deps = ["@bazel_tools//tools/bash/runfiles"],
|
|
)
|