GitHub/flatbuffers
1
0
Fork 0
mirror of https://github.com/google/flatbuffers.git synced 2025-04-08 09:12:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix LongEnum definitions (#7596)

Browse Source 
The MyGame/Example/LongEnum.java class did not compile because
Java expects an "L" suffix for literals of type long.

This CL fixes the code generation to include such a suffix.

Co-authored-by: Dominic Battre <battre@chromium.org>
This commit is contained in:
Dominic Battre 2022-10-21 03:15:00 +02:00 committed by GitHub
parent 5792623df4
commit f7b734438d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
java/pom.xml
View File

@ -63,7 +63,6 @@
<configuration>
<release>8</release>
<testExcludes>
<testExclude>**/LongEnum.java</testExclude>
<testExclude>MyGame/Example/MonsterStorageGrpc.java</testExclude>
<testExclude>MyGame/Example/StructOfStructs**</testExclude>
<testExclude>MyGame/OtherNameSpace/TableBT.java</testExclude>

4
src/idl_gen_java.cpp
View File

@ -397,6 +397,10 @@ class JavaGenerator : public BaseGenerator {
code += " ";
code += namer_.Variant(ev) + " = ";
code += enum_def.ToString(ev);
if (enum_def.underlying_type.base_type == BASE_TYPE_LONG ||
enum_def.underlying_type.base_type == BASE_TYPE_ULONG) {
code += "L";
}
code += ";\n";
}

6
tests/MyGame/Example/LongEnum.java
View File

@ -5,8 +5,8 @@ package MyGame.Example;
@SuppressWarnings("unused")
public final class LongEnum {
private LongEnum() { }
public static final long LongOne = 2;
public static final long LongTwo = 4;
public static final long LongBig = 1099511627776;
public static final long LongOne = 2L;
public static final long LongTwo = 4L;
public static final long LongBig = 1099511627776L;
}